Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for disabling context ref mismatch for pds4.collection and pds4.bundle rules #951

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

jordanpadams
Copy link
Member

🗒️ Summary

Fix for disabling context ref mismatch for pds4.collection and pds4.bundle rules

⚙️ Test Data and/or Report

See new test case added

♻️ Related Issues

Resolves #950

Adding test that currently fails per #950
@al-niessner al-niessner marked this pull request as ready for review August 8, 2024 16:51
Copy link
Contributor

@al-niessner al-niessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real solution is remove the individual setting and add clone() to RuleContext so that it just moves all values blindly.

@jordanpadams jordanpadams merged commit 1a38e2b into main Aug 9, 2024
3 checks passed
@jordanpadams jordanpadams deleted the i950 branch August 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--disable-context-mismatch-warnings only works for rule pds4.label
2 participants