Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for disabling context ref mismatch for pds4.collection and pds4.bundle rules #951

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Fix for disabling context ref mismatch for pds4.collection and pds4.bundle rules #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a81dee
Add test for disabling context ref mismatch
jordanpadams Jul 3, 2024
524d51c
add the disable to the test
Aug 8, 2024
178d006
Merge branch 'main' of github.com:NASA-PDS/validate into i950
Aug 8, 2024
c508de4
propigate values
Aug 8, 2024
698e73f
Merge branch 'main' of github.com:NASA-PDS/validate into i950
Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/gov/nasa/pds/tools/validate/rule/AbstractValidationRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ protected RuleContext getChildContext(URL child)
newContext.setLabelExtension(context.getLabelExtension());
newContext.setLabelPattern(context.getLabelPattern());
newContext.setLastDirectoryFlag(context.isLastDirectory());

newContext.setEveryN(this.context.getEveryN());
newContext.setContextMismatchAsWarn(this.context.getContextMismatchAsWarn());
return newContext;
}

Expand Down
3 changes: 3 additions & 0 deletions src/test/resources/features/developer.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ Scenario Outline: Execute validate command for tests below.
Examples:
| testName | testDir | messageCount | messageText | problemEnum | resourceDir | reportDir | commandArgs | refOutputValue |

# Validate#950
|"NASA-PDS/validate#950 Disable context ref mismatch collection" | "github915" | 0 | "0 warnings expected" | "CONTEXT_REFERENCE_FOUND_MISMATCH_WARN" | "src/test/resources" | "target/test" | "-r {reportDir}/report_github950.json -s json --skip-content-validation --disable-context-mismatch-warnings -R pds4.collection -t {resourceDir}/github915/collection.xml" | "report_github950.json" |

# Validate#919
|"NASA-PDS/validate#919 Success with 61 bit value" | "github919" | 0 | "0 errors expected" | "totalErrors" | "src/test/resources" | "target/test" | "-r {reportDir}/report_github919.json -s json --skip-context-validation -t {resourceDir}/github919/uh0003b_draft.xml" | "report_github919.json" |

Expand Down