Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2853 - crash on roms data #2943

Merged
merged 11 commits into from
Jan 6, 2022
Merged

Fixes 2853 - crash on roms data #2943

merged 11 commits into from
Jan 6, 2022

Conversation

clyne
Copy link
Collaborator

@clyne clyne commented Dec 21, 2021

Fixes #2853

This PR fixes #2853.

It also makes substantial progress toward #2765 - complete refactoring of grid class. Namely, it overloads the Grid class constructors with versions that use CoordType or DimsType (std::array) instead of std::vector. The only remaining item to complete #2765 would be to remove the overloaded, deprecated methods in Grid.h (and derived classes) that still use std::vector instead of std::array.

Note, this PR will not pass CI testing until #2944 is fixed.

I've opened this PR in draft status. Due to the number of changes, we may want to consider postponing merging this PR until after the 3.6 release.

@clyne clyne marked this pull request as draft December 22, 2021 02:48
@clyne clyne requested review from StasJ and shaomeng December 22, 2021 02:48
@clyne
Copy link
Collaborator Author

clyne commented Dec 29, 2021

Waiting for @sgpearse to fix #2944 so this PR will best CI testing

* fix 2944 by adding offset to resampled extents

* test

* Only reduce maximum extents

* clang format

* update extents with comment

* remove old code

* Update dataMgrTools.cpp

Co-authored-by: clyne <clyne@ucar.edu>
@clyne clyne marked this pull request as ready for review January 6, 2022 20:06
@clyne clyne merged commit 54646af into main Jan 6, 2022
@clyne clyne deleted the issue_2853 branch January 6, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on ROMS data
4 participants