Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when calculating 2D wind speed #3059

Closed
sgpearse opened this issue Mar 1, 2022 · 1 comment · Fixed by #3061
Closed

Crash when calculating 2D wind speed #3059

sgpearse opened this issue Mar 1, 2022 · 1 comment · Fixed by #3061
Assignees
@clyne
Labels
Bug High
Milestone
3_7_0_Release

Comments

@sgpearse
Copy link
Collaborator

sgpearse commented Mar 1, 2022

To reproduce:

  1. Load any dataset with 2D wind variables (katrina will work)
  2. Create a wind speed variable like what's shown below. The mismatched grids of the two variables do not matter.
from numpy import *
speed=sqrt(U10*U10+V10*V10)

Vapor will crash.
@sgpearse
Copy link
Collaborator Author

sgpearse commented Mar 1, 2022

@clyne, I ran a bisect and this appears to be a regression after we merged #2943, which addressed a crash on ROMS data. This PR is pretty big with 69 files changed.

I can work around this problem for now by running an older version of Vapor when I need to calculate 2D wind speed.

clyne added a commit that referenced this issue Mar 5, 2022
@clyne
Fixed #3059 - Crash when calculating 2D wind speed
ae698ed
@clyne clyne mentioned this issue Mar 5, 2022
Merged
clyne added a commit that referenced this issue Mar 8, 2022
@clyne
Fixed Crash when calculating 2D wind speed (#3061)
9a1e072 
* Change return type of Grid::GetCoordDimensions() from vector <size_t>
to DimsType for consistencey with rest of API.

* Fixed #3059 - Crash when calculating 2D wind speed

* clang-format pre-push hook
@sgpearse sgpearse added this to the 3_7_0_Release milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clyne clyne

Labels
Bug High
Projects
None yet
Milestone
3_7_0_Release
Development

Successfully merging a pull request may close this issue.

Fixed Crash when calculating 2D wind speed NCAR/VAPOR
2 participants
@clyne @sgpearse