Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Crash when calculating 2D wind speed #3061

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Fixed Crash when calculating 2D wind speed #3061

merged 3 commits into from
Mar 8, 2022

Conversation

clyne
Copy link
Collaborator

@clyne clyne commented Mar 5, 2022

Fixed #3059

PyEngine was still using vector<size_t> to represent grid indices. Converted to DimsType

@clyne clyne requested review from shaomeng and sgpearse March 5, 2022 19:10
sgpearse
sgpearse approved these changes Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@sgpearse sgpearse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks John.

shaomeng
shaomeng approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@shaomeng shaomeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks John!

@clyne clyne merged commit 9a1e072 into main Mar 8, 2022
@clyne clyne deleted the issue_3059 branch March 8, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgpearse sgpearse sgpearse approved these changes

@shaomeng shaomeng shaomeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when calculating 2D wind speed
3 participants
@clyne @shaomeng @sgpearse