Flow cleanup, Google Test #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remove Google Tests integration for now until further discussion. |
added 2 commits
February 20, 2024 14:01
This PR is ready to be reviewed without GTest. |
StasJ
requested changes
Feb 21, 2024
StasJ
approved these changes
Feb 22, 2024
sgpearse
reviewed
Feb 23, 2024
sgpearse
approved these changes
Feb 23, 2024
|
This PR is approved, I'll merge it to main so that Leigh can try it out! |
sgpearse
pushed a commit
that referenced
this pull request
Mar 1, 2024
* changes to the pointer cache, and also add the google test framework * incr * minor * format * remove debug code * remove gtest * remove gtest * minor --------- Co-authored-by: Samuel Li <shaomeng@cisl-vapor>
NihanthCW
pushed a commit
that referenced
this pull request
Mar 12, 2024
* test * test test test test test test Test test test test test test test * Flow cleanup, Google Test (#3539) * changes to the pointer cache, and also add the google test framework * incr * minor * format * remove debug code * remove gtest * remove gtest * minor --------- Co-authored-by: Samuel Li <shaomeng@cisl-vapor> * test * cleanup * improve Categories values * Add Geoscience category * Fix typo --------- Co-authored-by: Samuel Li <shaomeng@users.noreply.github.com> Co-authored-by: Samuel Li <shaomeng@cisl-vapor>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some flow code, including fixing a pointer consistency issue.