-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal Linux Installer #3554
Conversation
* changes to the pointer cache, and also add the google test framework * incr * minor * format * remove debug code * remove gtest * remove gtest * minor --------- Co-authored-by: Samuel Li <shaomeng@cisl-vapor>
Hey @sgpearse , this PR seems out of date with regard to the main branch. Could you pull the latest main to this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting! Just the one comment on the .desktop category
.circleci/config.yml
Outdated
- run: | ||
name: acquire intel hpckit for bundling ospray | ||
command: | | ||
# For bundling Ospray, which wants Intel's MPI implementation tobe bundled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? "to be" bundled ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Scott!
Fixes #3519 by generating an AppImage on top of our Ubuntu20 installer using linuxdeployqt to bundle additional Qt dependencies and libraries; and then appimagetool to generate the AppImage bundle itself.
To generate an AppImage, you can generate an installer on Ubuntu20 after setting DIST_APPIMAGE=ON in CMake. It of OFF by default. The build_ubuntu20_installer job in CircleCI will generate both our installer script, as well as the AppImage, and save them as artifacts.
The AppImage is generated by CMake launching the genAppImage.sh script after the .sh installer is created.
The structure of an AppImage also requires the addition of: