Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Linux Installer #3554

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Universal Linux Installer #3554

merged 9 commits into from
Mar 12, 2024

Conversation

sgpearse
Copy link
Collaborator

@sgpearse sgpearse commented Mar 1, 2024

Fixes #3519 by generating an AppImage on top of our Ubuntu20 installer using linuxdeployqt to bundle additional Qt dependencies and libraries; and then appimagetool to generate the AppImage bundle itself.

To generate an AppImage, you can generate an installer on Ubuntu20 after setting DIST_APPIMAGE=ON in CMake. It of OFF by default. The build_ubuntu20_installer job in CircleCI will generate both our installer script, as well as the AppImage, and save them as artifacts.

The AppImage is generated by CMake launching the genAppImage.sh script after the .sh installer is created.

The structure of an AppImage also requires the addition of:

  1. an AppRun script, which specifies how to launch the binaries within the AppImage
  2. A desktop file, which contains metadata about the AppImage
  3. An icon file. Unfortunately, AppImage does not operate on Apples .icns file format, Windows' .ico file format, and so now we have a .png icon for Linux.

sgpearse and others added 5 commits February 28, 2024 07:21
test

test

test

test

test

Test

test

test

test

test

test

test
* changes to the pointer cache, and also add the google test framework

* incr

* minor

* format

* remove debug code

* remove gtest

* remove gtest

* minor

---------

Co-authored-by: Samuel Li <shaomeng@cisl-vapor>
@NihanthCW NihanthCW requested review from shaomeng and StasJ March 7, 2024 19:14
@shaomeng
Copy link
Contributor

shaomeng commented Mar 7, 2024

Hey @sgpearse , this PR seems out of date with regard to the main branch. Could you pull the latest main to this branch?

Copy link
Collaborator

@StasJ StasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Just the one comment on the .desktop category

buildutils/vapor.desktop Outdated Show resolved Hide resolved
@sgpearse sgpearse requested a review from StasJ March 11, 2024 23:39
- run:
name: acquire intel hpckit for bundling ospray
command: |
# For bundling Ospray, which wants Intel's MPI implementation tobe bundled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? "to be" bundled ?

@shaomeng shaomeng self-requested a review March 11, 2024 23:42
Copy link
Contributor

@shaomeng shaomeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Scott!

@NihanthCW NihanthCW merged commit 17bfa4a into main Mar 12, 2024
1 of 2 checks passed
@sgpearse sgpearse deleted the appImage branch October 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal Linux Installer
4 participants