Add CCPP-compliant CNVC90 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These four PRs are related and should be merged together: #74 |
climbfuji
requested review from
llpcarson,
ligiabernardet,
grantfirl and
kellylittleblackdog
This was referenced Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one out of four (!) for NEMSfv3gfs and its submodules, ccpp-framework, ccpp-physics and FV3 that enables running the CCPP-compliant version of cnvc90 either directly from FV3/gfsphysics/physics (i.e. the current version in the FV3 trunk), or directly from ccpp/physics/physics (i.e. the CCPP-compliant version, but w/o using the CCPP framework), or via the CCPP-framework.
These three options exist for the Intel compiler only, for GNU and PGI, only the first and last options are available (i.e. cannot run the CCPP-compliant version without the CCPP framework).
Bit for bit tests:
results are identical for the CCPP build compared to the standard, non-CCPP build for the two tests run (fv3_control and fv3_gfdlmp) on Theia+{Intel,GNU,PGI} and on MacOSX+GNU
results are identical for the non-CCPP build compared to the official baseline on Theia+Intel15
a new baseline using Intel18 is currently created on Theia, in order to compare against this baseline, one must
tests/rt.shand add the following line after line 183:NEW_BASELINE=/scratch4/NCEPDEV/stmp4/Dom.Heinzeller/FV3_RT/REGRESSION_TEST_INTEL-mflag when running the regression tests viart.shAll related PRs will be listed in a comment below and will refer to this description.