Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(1) Add CCPP-compliant CNVC90 and (2) update standard names in metadata tables #90

Merged
merged 4 commits into from
Jun 1, 2018
Merged

(1) Add CCPP-compliant CNVC90 and (2) update standard names in metadata tables #90

merged 4 commits into from
Jun 1, 2018

Conversation

climbfuji
Copy link
Collaborator

Part 1: see description in NCAR/ccpp-framework#74

Part 2: several standard names are updated based on corrections that came up in the last weeks:

  • cloud_condensed_water_specific_humidity_updated_by_physics -> cloud_condensed_water_mixing_ratio_updated_by_physics
  • height_above_mean_sea_level_at_lowest_model_layer -> height_above_ground_at_lowest_model_layer
    These changes are made in the CCPP-version of GFS_typedefs.F90 and also in the NEMSfv3gfs-FV3 version of GFS_typedefs.F90. Appropriate changes will need to be made for SCM.

…idity_updated_by_physics to cloud_condensed_water_mixing_ratio_updated_by_physics and height_above_mean_sea_level_at_lowest_model_layer to height_above_ground_at_lowest_model_layer
…/gscond.f physics/precpd.f: rename cloud_condensed_water_specific_humidity_updated_by_physics to cloud_condensed_water_mixing_ratio_updated_by_physics
…vel_at_lowest_model_layer to height_above_ground_at_lowest_model_layer
@climbfuji
Copy link
Collaborator Author

@climbfuji
Copy link
Collaborator Author

@grantfirl note the comment about changes to the metadata tables (standard_name) in the description of the PR

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji
Copy link
Collaborator Author

@grantfirl I will take care of the standard_name changes for SCM in the next hour

@climbfuji climbfuji merged commit 7918420 into NCAR:master Jun 1, 2018
@climbfuji climbfuji deleted the update_standard_names_add_cnvc90 branch June 1, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants