-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial NoahMP docs to CCPP scientific docs #345
Conversation
grantfirl
commented
Oct 25, 2019
•
edited
Loading
edited
- Add NoahMP to "all schemes" list
- wrote stub for NoahMP "landing page"
- landing page points to existing NCAR NoahMP documentation and main paper
- landing page also documents the "MP" options chosen by EMC
- Doxygen configuration file edited to find NoahMP source code and landing page
- Library.bib updated with NoahMP references
- added Doxygen markup to put all NoahMP-related subroutines in NoahMP doxygen group
- minor code change in module_sf_noahmplsm.f90 for doxygen to be able to parse the file
- added brief descriptions and general algorithm section for subroutines in sfc_noahmp_drv.f
@mzhangw Added as reviewer to make sure I'm not doing something wrong |
TODO:
|
@ligiabernardet Note that what is currently here might be sufficient for purposes of the release since it covers the basics. I wouldn't classify it as done, since there are things that could be added to improve, but this is a reasonable place to start for a non-operational scheme (although it should definitely be finished by the time GFS v16 goes operational). |
@grantfirl @ligiabernardet @mzhangw can this be merged now? |
I would like to pull this into #366 and merge it into dtc/develop as it is now. Please let me know if that's ok. |
Just put in an update to reflect info from Helin. Let me run doxygen real quick to verify it looks OK. |
d295104
to
e0e91d8
Compare
@climbfuji All good for now. |
This PR has been pulled into #366 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge this PR as it will be merged automatically with #366.
* add flexibile output time * add fcst_mpi_comm to GFS_init_type Init_parm in atmos_model_init, remove commglobal communicator * update output_fh for fms history output, fix output_startfh initialization