Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial NoahMP docs to CCPP scientific docs #345

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 25, 2019

  • Add NoahMP to "all schemes" list
  • wrote stub for NoahMP "landing page"
  • landing page points to existing NCAR NoahMP documentation and main paper
  • landing page also documents the "MP" options chosen by EMC
  • Doxygen configuration file edited to find NoahMP source code and landing page
  • Library.bib updated with NoahMP references
  • added Doxygen markup to put all NoahMP-related subroutines in NoahMP doxygen group
  • minor code change in module_sf_noahmplsm.f90 for doxygen to be able to parse the file
  • added brief descriptions and general algorithm section for subroutines in sfc_noahmp_drv.f

@grantfirl
Copy link
Collaborator Author

@mzhangw Added as reviewer to make sure I'm not doing something wrong

@grantfirl grantfirl requested a review from mzhangw October 25, 2019 23:16
@grantfirl
Copy link
Collaborator Author

TODO:

  • write brief descriptions for main subroutines within NoahMP code
  • incorporate potential additions/edits from EMC colleagues
  • incorporate potential additions from Mike Barlage
  • add NoahMP namelist parameters to "Namelist Options Description" page?

@grantfirl
Copy link
Collaborator Author

@ligiabernardet Note that what is currently here might be sufficient for purposes of the release since it covers the basics. I wouldn't classify it as done, since there are things that could be added to improve, but this is a reasonable place to start for a non-operational scheme (although it should definitely be finished by the time GFS v16 goes operational).

@climbfuji
Copy link
Collaborator

@grantfirl @ligiabernardet @mzhangw can this be merged now?

@climbfuji
Copy link
Collaborator

I would like to pull this into #366 and merge it into dtc/develop as it is now. Please let me know if that's ok.

@grantfirl grantfirl changed the base branch from gmtb/develop to dtc/develop December 6, 2019 04:05
@grantfirl
Copy link
Collaborator Author

Just put in an update to reflect info from Helin. Let me run doxygen real quick to verify it looks OK.

@grantfirl
Copy link
Collaborator Author

@climbfuji All good for now.

@climbfuji
Copy link
Collaborator

This PR has been pulled into #366

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge this PR as it will be merged automatically with #366.

@climbfuji climbfuji merged commit e0e91d8 into NCAR:dtc/develop Dec 9, 2019
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
* add flexibile output time
* add fcst_mpi_comm to GFS_init_type Init_parm in atmos_model_init, remove commglobal communicator
* update output_fh for fms history output,  fix output_startfh initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants