Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtc/develop: collect updates to CCPP physics 2019/12/05 #366

Merged
merged 12 commits into from
Dec 9, 2019
Merged

dtc/develop: collect updates to CCPP physics 2019/12/05 #366

merged 12 commits into from
Dec 9, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 5, 2019 •
edited
Loading

This PR updates ccpp-physics with the following changes:

grantfirl and others added 5 commits October 25, 2019 17:02
@grantfirl
add initial NoahMP docs to CCPP scientific docs
8d7970c
@bluefinweiwei
modified: cires_ugwp.F90
12b644a 
	modified:   cires_ugwp_triggers.F90
	modified:   docs/ccpp_doxyfile
	modified:   docs/library.bib
	new file:   docs/pdftxt/UGWPv0.txt
	modified:   docs/pdftxt/all_shemes_list.txt
	modified:   ugwp_driver_v0.F
@grantfirl
replace MPI_ABORT in physics/module_MP_FER_HIRES.F90 with setting CCP…
e989adc 
…P errmsg and errflg
@grantfirl
move calculation of precipitation rates needed by NoahMP LSM to GFS_M…
7d9cf52 
…P_generic_post_run from sfc_noahmp_pre; sfc_noahmp_pre no longer needed
@climbfuji
Merge branch 'fix_no_mpi_compile_FA' of https://github.com/grantfirl/…
c2ea31b 
…ccpp-physics into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
@climbfuji climbfuji mentioned this pull request Dec 5, 2019
Merged
This was referenced Dec 6, 2019
Merged
Merged
Merged
grantfirl and others added 6 commits December 5, 2019 21:10
@grantfirl
update the NoahMP mainpage to reflect info from Helin Wei
e0e91d8
@climbfuji
Merge branch 'NoahMP_docs' of https://github.com/grantfirl/ccpp-physics…
b10e93b 
… into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
@climbfuji
Merge branch 'ugwp_doc' of https://github.com/bluefinweiwei/ccpp-physics
feb0a39 
 into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
@climbfuji
Merge branch 'fix_noahmp_precip_rates' of https://github.com/grantfir…
4dbe318 
…l/ccpp-physics into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
@grantfirl
fix array dimensions for phii, prsi in ugwp_driver_v0.F
812f8b6
@climbfuji
Merge branch 'fix_cires_ugwp_dimension_bug' of https://github.com/gra…
49deeca 
…ntfirl/ccpp-physics into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
@climbfuji climbfuji mentioned this pull request Dec 6, 2019
Merged
@climbfuji climbfuji marked this pull request as ready for review December 8, 2019 13:48
@climbfuji
Copy link
Collaborator Author

Associated PRs:

#366
NCAR/fv3atm#15
NCAR/ufs-weather-model#11

See NCAR/ufs-weather-model#11 for regression testing.

This was referenced Dec 8, 2019
Merged
Merged
@climbfuji climbfuji changed the title Collect updates to CCPP physics 2019/12/05 dtc/develop: collect updates to CCPP physics 2019/12/05 Dec 8, 2019
grantfirl
grantfirl approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@climbfuji climbfuji merged commit 02812f6 into NCAR:dtc/develop Dec 9, 2019
@climbfuji climbfuji deleted the update_dtc_develop_from_emc_develop_and_collect_updates_20191205 branch June 27, 2022 03:26
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
@climbfuji @mzhangw @mark-a-potts
Wrapper PR for NCAR#366 (remove redundant surface variables) and NCAR…
6bad820 
…#363 (send correct pointers to JEDI) (NCAR#368)

* clean up redundant surface variables
* Updates to send correct pointers to JEDI 

Co-authored-by: man.zhang <Man.Zhang@noaa.gov>
Co-authored-by: Mark Potts <Mark.Potts@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl approved these changes

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

@llpcarson llpcarson Awaiting requested review from llpcarson

@bluefinweiwei bluefinweiwei Awaiting requested review from bluefinweiwei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climbfuji @grantfirl @bluefinweiwei