fix array dimensions for phii, prsi in ugwp_driver_v0.F #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantfirl
requested review from
climbfuji,
JulieSchramm and
llpcarson
as code owners
|
Associated PR: |
climbfuji
reviewed
Dec 6, 2019
| @@ -48,7 +48,9 @@ subroutine cires_ugwp_driver_v0(me, master, | |||
| &, rain | |||
|
|
|||
| real(kind=kind_phys), intent(in), dimension(im,levs) :: ugrs | |||
| &, vgrs, tgrs, qgrs, prsi, prsl, prslk, phii, phil, del | |||
| &, vgrs, tgrs, qgrs, prsl, prslk, phil, del | |||
There was a problem hiding this comment.
Just noting that this code is commented out (ifdef-ed out) in ccpp-physics: the entire block lines 16-253 (subroutine cires_ugwp_driver_v0) is not used in CCPP.
The corresponding code in cires_ugwp.{F90,meta} has the correct dimensions for phii and prsi.
There was a problem hiding this comment.
I definitely did not notice that! Wouldn't that explain why debug mode compilation wouldn't catch this? I'm guessing that the associated PR for the non-CCPP version is exercised though?
|
This PR has been pulled into #366 (although the affected code is not exercised at all - ifdef-ed out). |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an emergency bugfix found by Valery Yudin, communicated through email to @grantfirl.