-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix on the production of diagnostic variables in rollout_to_netcdf.py
+ credit.postblock
update + other minor bugfix
#120
Conversation
You may see some I have pushed new commits to align it with the main branch. There are no Wxformer updates in this PR |
rollout_to_netcdf.py
+ other minor bugfixrollout_to_netcdf.py
+ credit.postblock
update + other minor bugfix
…g in single-step trainer
Ready |
Merge conflicts resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new postblock physics and diagnostic updates look good to me. I fixed the CI issue and ran some formatting fixes and removed some unused imports and variables that were flagged by PyCharm. I also want to mention a couple of formatting/style conventions to encourage going forward
- We use Google-style docstrings across MILES projects, which follow the following format:
"""
short description of what function/method does
Args
first_arg (type): blah
second_arg (type): blah
Returns
variable (type): description of thing being returned
"""
Please use double-quotes instead of single quotes for consistency purposes. Both types are interchangeable in Python as long as one uses the same type at the beginning and end of a string, but I suspect style guides encourage double quotes because in some languages single quotes can only be used for character types.
New feature
GlobalMassFixer
; it now has its ownGlobalWaterFixer
.GlobalMassFixer
,GlobalWaterFixer
, andGlobalEnergyFixer
can now run outside of the model (i.e., they can run insidecredit.trainer
androllout_to_netcdf.py
).Bugfix
rollout_to_netcdf.py
credit.output
now produces files with coordinate names oflatitude
andlongitude
rather than 'lat/lon'credit.physcis_constants
values were updated to align with CAM6GlobalMassFixer
to handle "half level" vertical coordinatesNote
rollout_to_netcdf.py
. It maintains the structure of the current script and touches diagnostic variables only.rollout_to_netcdf.py
can be improved fundamentally, but not in this PR.(i.e., produce model weights --> use weights to verify rollout)