-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update for the inference routine + QoL improvements #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingkaisha
changed the title
Major update for the inference routine + QoL improvements of the data workflow
Major update for the inference routine + QoL improvements
Dec 8, 2024
Done. Some files are touched because of the ruff reformat. |
jsschreck
reviewed
Jan 1, 2025
jsschreck
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
Now
grad_max_norm: 0
will turn off gradient clippingIn
credit.parser
,conf['trainer']['mode']
is verified to be one of thefsdp
,ddp
, ornone
.In
credit.parser
, the data availability checks now produce warnings instead of errors.The following config options will now trigger warnings:
use_spectral_norm: False
andmode: fsdp
--- this does not work. The reason is unknown.Datasets defined in
rollout_to_netcdf.py
androllout_metrics.py
are now combined asPredict_Dataset_Iter
incredit.data
Bugfix
rollout_to_netcdf.py
+credit.postblock
update + other minor bugfix #120 is fixed inrollout_metrics.py
.rollout_to_netcdf.py
androllout_metrics.py
for ddp and single-GPU mode.