Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update for the inference routine + QoL improvements #134

Merged
merged 17 commits into from
Jan 6, 2025
Merged

Conversation

yingkaisha
Copy link
Collaborator

@yingkaisha yingkaisha commented Dec 8, 2024

New features

  • Now grad_max_norm: 0 will turn off gradient clipping

  • In credit.parser, conf['trainer']['mode'] is verified to be one of the fsdp, ddp, or none.

  • In credit.parser, the data availability checks now produce warnings instead of errors.

    • If you require to predict 2024 but only have data up to 2023, you will receive warnings, and the inference routine will stop at the end of 2023.
  • The following config options will now trigger warnings:

    • FuXi with use_spectral_norm: False and mode: fsdp --- this does not work. The reason is unknown.
  • Datasets defined in rollout_to_netcdf.py and rollout_metrics.py are now combined as Predict_Dataset_Iter in credit.data

Bugfix

@yingkaisha yingkaisha changed the title Major update for the inference routine + QoL improvements of the data workflow Major update for the inference routine + QoL improvements Dec 8, 2024
@yingkaisha
Copy link
Collaborator Author

Done.

Some files are touched because of the ruff reformat.

credit/data.py Outdated Show resolved Hide resolved
@yingkaisha yingkaisha merged commit c095e95 into main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants