-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMA to Dask: arithmetic, logical & comparison operators #409
LAMA to Dask: arithmetic, logical & comparison operators #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sadie. A quick review, as I know that there is more work to done ...
notably since I am about to add a commit or two applying elemwise calls to the operations that give the results
I don't really understand what these elemwise
calls could be for - am I missing something?
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Thanks for all of your feedback (so far) @davidhassell, which I have now addressed fully as far as I can tell. Unless you have further comments, this should be ready to merge now, though I would like to also first check that I was OK to 'deprecate' our custom function |
(CI jobs failing or cancelled due to trying to use the wrong |
Hi Sadie - all looks good to me, thanks. As |
Convert all of the arithmetic, logical & comparison operators from LAMA to Dask. Please cross-reference with #295 for the precise listing of methods being migrated here, if necessary.