Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAMA to Dask: arithmetic, logical & comparison operators #409

Merged
merged 22 commits into from
Jun 20, 2022
Merged

LAMA to Dask: arithmetic, logical & comparison operators #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
885a6f7
Comment to mark arithmetic & similar methods to be migrated to dask
sadielbartholomew Mar 15, 2022
516cd4d
Apply basic tidy to un-daskified '_binary_operation' method
sadielbartholomew Mar 16, 2022
84f0439
Test-driven development: un-skip relevant test to monitor migration
sadielbartholomew Mar 16, 2022
2454108
Apply converted units post-operation in _binary_arithmetic
sadielbartholomew Mar 21, 2022
8e74e0f
Add outline of logic for _binary_arithmetic migrated to use Dask
sadielbartholomew Mar 17, 2022
50e75b2
Add logic to perform operation not in-place in _binary_arithmetic
sadielbartholomew Mar 21, 2022
77911be
Skip test case failing on unmigrated method RE _binary_arithmetic
sadielbartholomew Jun 9, 2022
735171d
Add logic to perform operation in-place in _binary_arithmetic
sadielbartholomew Jun 13, 2022
6c8cb19
Skip new test case failing on unmigrated method RE _binary_arithmetic
sadielbartholomew Jun 13, 2022
9313d6a
Tidy updated _binary_arithmetic & mark as 'daskified'
sadielbartholomew Jun 13, 2022
16649c7
Fix 2x undefined name errors caught in _binary_arithmetic
sadielbartholomew Jun 13, 2022
ff847ef
Mark all arithmetic, logical & comparison operators as 'daskified'
sadielbartholomew Jun 14, 2022
5caa169
Update cf/data/data.py: _get_dask -> to_dask_array
sadielbartholomew Jun 15, 2022
4775f13
Update cf/data/data.py: _get_dask -> to_dask_array (2)
sadielbartholomew Jun 15, 2022
7b1f543
Update cf/data/data.py: remove deprecated kwarg to _set_dask
sadielbartholomew Jun 15, 2022
ad09bf7
Update cf/data/data.py: remove deprecated kwarg to _set_dask (2)
sadielbartholomew Jun 15, 2022
e832e85
Address feedback: improve commenting in _binary_arithmetic section
sadielbartholomew Jun 17, 2022
7f05719
Address feedback: remove redundant catch in _binary_arithmetic
sadielbartholomew Jun 17, 2022
742e48c
Address feedback: remove 2nd redundant catch in _binary_arithmetic
sadielbartholomew Jun 17, 2022
6f7d1d7
Update calls from cf's custom _numpy_isclose to da.isclose
sadielbartholomew Jun 17, 2022
2e71011
Deprecate (internal => remove) cf's now-redundant _numpy_isclose
sadielbartholomew Jun 17, 2022
3930cb7
Merge branch 'lama-to-dask' into lama-to-dask-binary-unary-arithmetic
sadielbartholomew Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading