Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_decorators issue by setting correct assertLogs levels #424

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Jul 18, 2022

Fixes #419

See NCAS-CMS/cfdm#197 for details.

@davidhassell davidhassell added this to the 3.13.1 milestone Jul 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #424 (7a1f29a) into master (a08ac1f) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   73.80%   74.25%   +0.46%     
==========================================
  Files          85       88       +3     
  Lines       19179    19713     +534     
==========================================
+ Hits        14153    14636     +483     
- Misses       5026     5077      +51     
Flag Coverage Δ
unittests 74.25% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main/cf/domain.py 67.00% <0.00%> (-8.00%) ⬇️
main/cf/constructs.py 91.43% <0.00%> (-4.02%) ⬇️
main/cf/data/partitionmatrix.py 93.34% <0.00%> (-1.53%) ⬇️
main/cf/regrid/regridoperator.py 94.34% <0.00%> (-1.21%) ⬇️
main/cf/dimensioncoordinate.py 68.68% <0.00%> (-0.96%) ⬇️
main/cf/__init__.py 80.71% <0.00%> (-0.87%) ⬇️
main/cf/formula_terms.py 88.38% <0.00%> (-0.48%) ⬇️
main/cf/data/partition.py 85.54% <0.00%> (-0.35%) ⬇️
main/cf/regrid/utils.py 60.39% <0.00%> (-0.04%) ⬇️
main/cf/data/data.py 78.97% <0.00%> (-0.01%) ⬇️
... and 31 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good save for a tweak to fix the changelog link. Notably, the full test suite passes locally with both my Python 3.10 and 3.9 conda environments.

You got at the test_decorators fix for cf-python before I could (popped it on my TODO list after completing the cfdm equivalent, to tackle after finishing up more urgent tasks), so thanks since I can tick that off now 😃

Please merge when ready.

Changelog.rst Outdated Show resolved Hide resolved
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell davidhassell merged commit 07cb04f into NCAS-CMS:master Jul 18, 2022
@davidhassell davidhassell deleted the py3.10_test_decorators branch November 15, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Python 3.10
3 participants