Set correct assertLogs levels to fix Py 3.10+ test_decorators
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
added
the
testing
davidhassell
approved these changes
Jul 15, 2022
This was referenced Jul 18, 2022
Closed
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses item two on the list in #187. It turns out that the issue at hand was in the
test_decoratorstesttest_manage_log_level_via_verbositymethod code to check logging outputs, which was set up incorrectly for three cases with regards to the minimum logging level (levelkwarg) being checked in the assertions which all relied on theassertLogsmethod.I'm not sure why said issue didn't appear with Python <3.10 versions, as nothing in the changelog for 3.10 suggests any behaviour change in that method or related aspects, but hey ho.
Probably doesn't require a review, as quite trivial, but feel free to look over it @davidhassell, else just merge straight in! I will add Python 3.10 to our Actions workflows shortly so we can test against 3.10.