-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternate versions #61
base: master
Are you sure you want to change the base?
Conversation
f20ffb2
to
5db6c9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this make it hard for someone to come to the SPARQL endpoint with a PMID, e.g. PMID:31431825
and make a query? Do they need to know to check for a version?
Hmm, good point. Right now, I include the original PMID with the triple: The key problem here is that AFAICT there's no way to tell whether a particular article is the most recent version or not except by looking for the largest version ID, which we can't do while processing the input as a stream. I previously considered filtering out older versions of articles when generating triples, but I'm loath to lose any potential information that might be there. I think maybe including the version number in the identifiers will make it clear that downstream users need to take the different versions into account when working with this data. For instance, I'm thinking of filtering out previous versions from the final tab-delimited output rather than messing with the triples themselves. What do you think? |
5db6c9f
to
7a7fdc0
Compare
This PR will be used to add support for alternate versions of PubMed articles (#61). For now, it just emits URLs that include the version number (e.g. https://www.ncbi.nlm.nih.gov/pubmed/31431825.2 to indicate version 2 of PMID 31431825).