Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supplementary courses from CS accelerator pages #2060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

croab
Copy link
Contributor

@croab croab commented Jun 3, 2024

Status

Review progress:

  • Browser tested
  • Tech review completed

What's changed?

  • Removed the 'View additional courses?' section and much of the supplementary activities logic as it is no longer used anywhere else.

Notes

  • This PR assumes that the supplementary courses feature (really a pathway activity) is no longer needed as it is only used in the page section which has been designated for removal. I have, however, left the ability to denote a course as supplementary intact as this is used still by the #recommended_activities method of Pathway. Ideally, we'd just identify all #recommended_activities as just pathway_activities without the boolean supplementary where filter since supplementary courses are no longer used. Pending response to whether we still need to identify supplementary courses at all.

@croab croab force-pushed the refactor/extra-courses-dropdown-on-dashboards branch 2 times, most recently from a53fa39 to ef4ab7f Compare June 3, 2024 07:27
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2060 June 3, 2024 07:39 Inactive
Copy link
Contributor

@GDTimi GDTimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine on the technical & frontend sides, pending confirmation on the supplementary attribute removal.

@croab croab mentioned this pull request Jun 11, 2024
33 tasks
@msquance-stem msquance-stem force-pushed the refactor/extra-courses-dropdown-on-dashboards branch from ef4ab7f to b3a4a00 Compare August 1, 2024 12:08
@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2060 August 1, 2024 12:21 Inactive
@msquance-stem msquance-stem force-pushed the refactor/extra-courses-dropdown-on-dashboards branch from b3a4a00 to 888b417 Compare August 6, 2024 12:07
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2060 August 6, 2024 12:07 Inactive
Copy link

sonarqubecloud bot commented Aug 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants