Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade/bump govuk frontend to 5.4.0 #2070

Merged
merged 18 commits into from
Jul 3, 2024
Merged

Upgrade/bump govuk frontend to 5.4.0 #2070

merged 18 commits into from
Jul 3, 2024

Conversation

croab
Copy link
Contributor

@croab croab commented Jun 10, 2024 •
edited by msquance-stem
Loading

Status

Review progress:

  • Browser tested
  • Tech review completed

What's changed?

  • Upgrade of govuk-frontend up to version 5.4.0

Outstanding issues

Only one outstanding after resolving the header thickness issue -

  • Could do with a thorough test, particularly of pages such as application-error.html and _base-certificate.html.erb

Progress

Necessary updates:

4.0.0:

  • Update the HTML for navigation in the header (small) - does not seem to be necessary
  • Include JavaScript for skip link to improve screen reader announcements (small) - need to test for application-error.html and base-certificate. Works fine for header.

4.3.0

  • Add hidden to the mobile menu button in the header component (small)

5.0.0-beta.0

  • Check your tags align with design changes to the Tag component (medium)
    • view/courses/_course_details.html.erb - looks OK now
    • views/certificates/cs_accelerator/_achievements.html.erb - looks OK now
    • views/components/_announcement.html.erb - doesn't look like it is used anymore
    • views/certificates/pathways/_supplementary_courses.html.erb - will be removed in Remove supplementary courses from CS accelerator pages #2060
    • views/certificates/cs_accelerator/_completed-achievements.html.erb - partial doesn't appear to be referenced anywhere??
    • views/components/cpd_course_component/cpd_course_component.html.erb
    • views/components/course_component/course_component.html.erb - component doesn't appear to be in use anymore
  • Update package file paths (small-medium)
  • Update the <script> snippet at the top of your <body> tag (small-medium)

5.0.0-beta.2

  • Check whether need to "update the GOV.UK logo" and "Check your favicons, app icons and OpenGraph image still work" (small-medium) - believe it is only the DoE logo on the site which doesn't appear to be any different

5.0.0

  • Consider the impact that 5.0.0 stops Internet Explorer 11 from running GOV.UK Frontend JavaScript and removes support completely for Internet Explorer 8 to 10. (small) - only 0.0009% in the last 12 months used IE
  • Update package file paths for Sass, assets such as images and fonts and Node.js and other bundlers (medium) - paths updated to use /dist. I don't believe any gov assets are being used.
  • Verify your code does not rely on polyfills we have now removed (small)
  • Stop Internet Explorer 11 and other older browsers running unsupported JavaScript (small) - wouldn't mind checking this is actually doing something / correct but doesn't seem to throw any errors at least. Also been unable to check for _base-certificate.html.erb

5.0.1

  • Replace uses of govuk-!-font-size-14 as deprecated (small) - turns out this is ok for now but ❗️deprecated and will be removed in 6.0.0❗️so should revise before then

5.3.0

  • Remove redundant role attributes from elements (medium)

5.4.0

  • Importing layers using all files (small)

Recommended

5.0.0-beta.0

  • Might need to make changes for "Customise inverse button colours" (small)

5.0.0-beta.2

  • Remove the X-UA-Compatible meta tag (small-medium)

5.2.0

  • Set $govuk-new-typography-scale: true; (small) - typography updates

New Features that could be nice to integrate

4.2.0

  • Help users navigate through pages with pagination

4.4.0

  • Change the Button component's background and text colour

4.7.0

  • Various inverse colour modifiers

5.0.0-beta.0

  • Use new focus style for links containing non-text content
  • Task list component
  • Can now customise inverse button colours

5.3.0

  • Password input component

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2070 June 10, 2024 15:38 Inactive
@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2070 June 11, 2024 15:22 Inactive
@croab croab force-pushed the upgrade/bump-govuk-frontend-to-5.4.0 branch from 6e7e852 to 307f248 Compare June 11, 2024 15:39
@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2070 June 11, 2024 15:39 Inactive
@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2070 June 11, 2024 16:45 Inactive
@msquance-stem
Removing IE reference in head
4bcb44d 
Removing test association with above
Tested the typographic settings, comment out for now, but will have some impact on design that we will need to investigate
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 13, 2024 10:02 Inactive
@msquance-stem
Removing commented out variable as it was crashing local tests for so…
7a6b0e0 
…me reason

Overriding the max-width on the aside_filter button, as this was breaking layout on phone
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 13, 2024 11:57 Inactive
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 13, 2024 15:49 Inactive
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 14, 2024 09:06 Inactive
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 14, 2024 12:02 Inactive
@msquance-stem
Adding a little bit of padding to the checkboxes to make it a bit nic…
97c5c71 
…er to look at

Adding computing to the svg title as its bugged me since I saw it was missing
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 14, 2024 12:24 Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.7% Duplication on New Code

See analysis details on SonarCloud

@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 June 19, 2024 13:52 Inactive
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2070 June 26, 2024 10:22 Inactive
A-Wheeto
A-Wheeto approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@A-Wheeto A-Wheeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2070 July 2, 2024 08:12 Inactive
@msquance-stem msquance-stem merged commit 8c27ac3 into main Jul 3, 2024
7 checks passed
@msquance-stem msquance-stem deleted the upgrade/bump-govuk-frontend-to-5.4.0 branch July 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Wheeto A-Wheeto A-Wheeto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@croab @A-Wheeto @tc-deploybot @msquance-stem