Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2889 implement cookieyes #2211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

2889 implement cookieyes #2211

wants to merge 4 commits into from

Conversation

A-Wheeto
Copy link
Contributor

@A-Wheeto A-Wheeto commented Nov 5, 2024

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Prep for implementing CookieYes by removing the current cookie consent banner
  • Removed javascript banner
  • Removed scss and imports

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2211 November 5, 2024 08:38 Inactive
@A-Wheeto A-Wheeto had a problem deploying to teachcomputing-pr-2211 November 5, 2024 09:13 Failure
@A-Wheeto A-Wheeto temporarily deployed to teachcomputing-pr-2211 November 5, 2024 10:04 Inactive
msquance-stem
msquance-stem approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@msquance-stem msquance-stem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msquance-stem msquance-stem force-pushed the 2889-implement-cookieyes branch from 4dc3ef6 to 4339718 Compare November 25, 2024 13:00
@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2211 November 25, 2024 13:11 Inactive
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2211 November 25, 2024 15:20 Inactive
@msquance-stem msquance-stem force-pushed the 2889-implement-cookieyes branch from 4339718 to 8d1c38c Compare November 29, 2024 10:54
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2211 November 29, 2024 10:54 Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msquance-stem msquance-stem msquance-stem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A-Wheeto @msquance-stem @tc-deploybot