Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2889 implement cookieyes #2211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

2889 implement cookieyes #2211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7db5123
Removing current cookie notice from the website in preparation for im…
A-Wheeto Nov 5, 2024
0dbc9c1
Remove cookie-notice.scss import
A-Wheeto Nov 5, 2024
f799235
Removing cookieconsent from packages
A-Wheeto Nov 5, 2024
8d1c38c
Removing import from application.js
A-Wheeto Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions app/webpacker/javascript/cookie_notice.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions app/webpacker/packs/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@
// or the `imagePath` JavaScript helper below.

import Rails from '@rails/ujs'
import 'cookieconsent'

// JS
import '../javascript/controllers'
import '../javascript/cookie_notice'
import '../javascript/courses'
import '../javascript/dropdown__expander'
import '../javascript/js_enabled'
Expand Down
1 change: 0 additions & 1 deletion app/webpacker/stylesheets/application.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
@import 'settings/_variables.scss';

// import NCCE components
@import 'components/_cookie-notice.scss';
@import 'components/_dropdown-expander.scss';
@import 'components/_footer.scss';
@import 'components/_gcse-revision.scss';
Expand Down
25 changes: 0 additions & 25 deletions app/webpacker/stylesheets/components/_cookie-notice.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"@rails/webpacker": "^5.4.3",
"ansi-html-community": "0.0.8",
"channels": "^0.0.4",
"cookieconsent": "^3.1.0",
"core-js": "^3.12.0",
"dotenv-webpack": "^8.0.1",
"flatpickr": "^4.6.9",
Expand Down
8 changes: 0 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3478,13 +3478,6 @@ __metadata:
languageName: node
linkType: hard

"cookieconsent@npm:^3.1.0":
version: 3.1.1
resolution: "cookieconsent@npm:3.1.1"
checksum: fe116972b901011ff03025b9fa9ed96ad8e570853cbb17b4ea86cc7713ab1944b884ebf2ff44f34da8c7f07d0b235b8491cde3327571fdd6f583c961a7694557
languageName: node
linkType: hard

"copy-concurrently@npm:^1.0.0":
version: 1.0.5
resolution: "copy-concurrently@npm:1.0.5"
Expand Down Expand Up @@ -7655,7 +7648,6 @@ __metadata:
"@rails/webpacker": ^5.4.3
ansi-html-community: 0.0.8
channels: ^0.0.4
cookieconsent: ^3.1.0
core-js: ^3.12.0
dotenv-webpack: ^8.0.1
eslint: ^7.25
Expand Down