GH-158 - Report the number of engagement reports submitted within a given time frame #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
search component
evdhoudt
changed the title
|
One commit probably refers to the wrong issue (should be #158). |
gjvoosten
requested changes
Oct 31, 2017
| } | ||
|
|
||
| public boolean getIncludeEngagementDayOfWeek() { | ||
| return (includeEngagementDayOfWeek == null) ? false : includeEngagementDayOfWeek; |
There was a problem hiding this comment.
Better to use:
return Boolean.TRUE.equals(includeEngagementDayOfWeek);
(should actually be changed elsewhere in the file as well).
| @@ -15,6 +15,8 @@ | |||
| Integer authorId; | |||
| DateTime engagementDateStart; | |||
| DateTime engagementDateEnd; | |||
| Integer engagementDayOfWeek; | |||
| Boolean includeEngagementDayOfWeek; | |||
There was a problem hiding this comment.
I prefer to make new fields private (at some point [e.g. when we have decided on a Checkstyle profile] we should consider changing them all).
| @@ -37,6 +37,7 @@ | |||
| DateTime releasedAt; | |||
|
|
|||
| DateTime engagementDate; | |||
| Integer engagementDayOfWeek; | |||
There was a problem hiding this comment.
I prefer to make new fields private (at some point [e.g. when we have decided on a Checkstyle profile] we should consider changing them all).
true on get methods
evdhoudt
commented
Oct 31, 2017
| } | ||
|
|
||
| if (value.end !== null) { | ||
| this.updateDate("endDate", moment(value.end)) |
There was a problem hiding this comment.
Fixed input to value.end
gjvoosten
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.