Refactoring plugin to enhance readability #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a configuration struct with all the parameters give by a users. The global variables, previously used, were removed and some function calls had to be adapted. Also removes some conditionals which were always true. Also removes "pig booleans" and replaces them with proper types to have more context and better readability in the code.
This commit puts the main function in a separate check_interfaces.c to make it more obvious what happens. The code is now (badly) separated from snmp_bulkget.c and needs further logical separation configure.ac is enhanced with this commit and the Makefile generation is now done from a Makefile.am, so the Makefile.in in this repository is theoretically obsolete. Some other (for now empty) files in here are just generated to satisfy the needs of the autoconf toolchain
|
Very nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.