Skip to content

Refactoring plugin to enhance readability #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 21, 2023
Merged

Refactoring plugin to enhance readability #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9211089
Refactor runtime configuration
RincewindsHat Jan 28, 2023
4e0f031
Remove trailing whitespaces
RincewindsHat Jan 28, 2023
36d9c88
Move command line parsing into a separate function
RincewindsHat Jan 28, 2023
82410d4
Execute workflows on branches
RincewindsHat Jan 28, 2023
d62005d
Remove unused variable addr_list
RincewindsHat Jan 28, 2023
07fd4c8
Reformatting because of misleading indentation
RincewindsHat Jan 28, 2023
788371f
Move stripping into the install part of the Makefile
RincewindsHat Jan 29, 2023
c5131f8
Initialise config with a nice struct literal
RincewindsHat Jan 30, 2023
bc863fa
Add clang-format config file
RincewindsHat Jan 30, 2023
ce088fd
Auto format code
RincewindsHat Jan 30, 2023
43db155
Autoupdate
Feb 20, 2023
71cca51
Remove unused parameter
Mar 6, 2023
6ef7d88
Change counter type to avoid sign comparison mismatch
Mar 6, 2023
5aa4840
Change toolchain
Mar 6, 2023
ca57cbb
Add necessary files for autotools
Mar 6, 2023
0a90393
Also add depcomp
Mar 6, 2023
d196fb3
Properly quote autoconf version in configure.ac
Mar 6, 2023
2fafe02
autoconf wants to have that newline
Mar 6, 2023
cebee8a
Remove useless assignements
Mar 20, 2023
f03cf65
clang-format
Mar 20, 2023
4bf235c
Add test build with clang
Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
UseTab: true
TabWidth: 4
IndentWidth: 4
24 changes: 22 additions & 2 deletions .github/workflows/makefile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,34 @@ name: Makefile CI

on:
push:
branches: [ "master" ]
branches: [ "*" ]
pull_request:
branches: [ "master" ]
branches: [ "*" ]

jobs:
build:
runs-on: ubuntu-latest
env:
CFLAGS: "-Wall"

steps:
- uses: actions/checkout@v3

- name: Install dependencies
run: |
sudo .github/prepare_ubuntu.sh

- name: configure
run: ./configure

- name: Make
run: make

clang-build:
runs-on: ubuntu-latest
env:
CC: clang
CFLAGS: "-Wall"

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 0 additions & 6 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,11 @@ autom4te.cache
/autoscan.log
/autoscan-*.log
/aclocal.m4
/compile
/config.guess
/config.h.in
/config.log
/config.status
/config.sub
/configure
/configure.scan
/depcomp
/install-sh
/missing
/stamp-h1

# https://www.gnu.org/software/libtool/
Expand Down
Empty file added AUTHORS
View file
Open in desktop
Empty file.
Empty file added ChangeLog
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions INSTALL
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/usr/share/automake-1.16/INSTALL
5 changes: 5 additions & 0 deletions Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
OBJS = snmp_bulkget.o utils.o

libexec_PROGRAMS = check_interfaces

check_interfaces_LDADD = $(OBJS)
Loading