Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support custom trigger for 0 width collapsed sider #1950

Closed
Supamiu opened this issue Aug 9, 2018 · 0 comments · Fixed by #2938
Closed

support custom trigger for 0 width collapsed sider #1950

Supamiu opened this issue Aug 9, 2018 · 0 comments · Fixed by #2938
Labels
Component: Layout 🌈 Feature Request

Comments

@Supamiu
Copy link

Supamiu commented Aug 9, 2018

What problem does this feature solve?

I'm trying to build an application with two siderbars, one for navigation, and the other one for a rapid access to some important informations. The first one is working great and has a nice sider trigger using the default one. But the second one should use a custom trigger template as I don't want the same icon. because [nzTrigger] only affects the trigger at the bottom of the page and not the one that shows when you have a 0px collapsed sider, I have no way to change it right now.

What does the proposed API look like?

simply have [nzTrigger] affect the collapsed trigger too, or have a [nzZeroWidthTrigger] property that takes a template too, in order to provide a custom icon for this trigger. Could also just be an icon string.
@Supamiu Supamiu mentioned this issue Aug 9, 2018
Closed
3 tasks
@vthinkxie vthinkxie removed the Has PR label Feb 19, 2019
@vthinkxie vthinkxie mentioned this issue Feb 20, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Feb 20, 2019
@vthinkxie
feat(module:layout): support zeroTrigger (#2938)
4e4231d 
* feat(module:layout): support zeroTrigger
close #1950 close #1951

* fix(module:layout): fix runoutside
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
feat(module:layout): support zeroTrigger (NG-ZORRO#2938)
2c723e5 
* feat(module:layout): support zeroTrigger
close NG-ZORRO#1950 close NG-ZORRO#1951

* fix(module:layout): fix runoutside
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
feat(module:layout): support zeroTrigger (NG-ZORRO#2938)
93c8381 
* feat(module:layout): support zeroTrigger
close NG-ZORRO#1950 close NG-ZORRO#1951

* fix(module:layout): fix runoutside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Layout 🌈 Feature Request
Projects
None yet
Milestone
No milestone
2 participants
@vthinkxie @Supamiu