Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:layout): support zeroTrigger #2938

Merged
merged 2 commits into from
Feb 20, 2019
Merged

feat(module:layout): support zeroTrigger #2938

merged 2 commits into from
Feb 20, 2019

Conversation

vthinkxie
Copy link
Member

close #1950 close #1951

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e065ec5

https://deploy-preview-2938--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #2938 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2938      +/-   ##
==========================================
+ Coverage   97.36%   97.37%   +<.01%     
==========================================
  Files         524      524              
  Lines       11043    11045       +2     
  Branches      782      782              
==========================================
+ Hits        10752    10755       +3     
  Misses        190      190              
+ Partials      101      100       -1
Impacted Files Coverage Δ
components/layout/demo/responsive.ts 100% <ø> (ø) ⬆️
components/layout/demo/side.ts 100% <ø> (ø) ⬆️
components/layout/demo/basic.ts 100% <ø> (ø) ⬆️
components/layout/demo/custom-trigger.ts 100% <ø> (ø) ⬆️
components/layout/nz-sider.component.ts 98.03% <100%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a4d06...e065ec5. Read the comment docs.

@vthinkxie vthinkxie merged commit 4e4231d into NG-ZORRO:master Feb 20, 2019
@vthinkxie vthinkxie deleted the zero-trigger branch February 26, 2019 07:08
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:layout): support zeroTrigger
close NG-ZORRO#1950 close NG-ZORRO#1951

* fix(module:layout): fix runoutside
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:layout): support zeroTrigger
close NG-ZORRO#1950 close NG-ZORRO#1951

* fix(module:layout): fix runoutside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support custom trigger for 0 width collapsed sider
1 participant