Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用OnPush策略的组件里，nz-modal关闭后页面失去焦点 #2643

Closed
HotEvent opened this issue Dec 17, 2018 · 1 comment
Closed

使用OnPush策略的组件里，nz-modal关闭后页面失去焦点 #2643

HotEvent opened this issue Dec 17, 2018 · 1 comment
Assignees
@hsuanxyz
Labels
🐛 Bug Component: Modal

Comments

@HotEvent
Copy link

Version

7.0.0-rc.1

Environment

ng-zorro-antd 7.0.0-rc.1

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-2dcrhp

Steps to reproduce

1.点击Show Modal按钮
2.关闭模态框
页面没有焦点

What is expected?

关闭模态框之后页面焦点与步骤1相同

What is actually happening?

页面没有焦点，得额外点击一次页面才能继续操作

Other?
@hsuanxyz hsuanxyz self-assigned this Dec 17, 2018
@IssueHuntBot
Copy link

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 19, 2018
@hsuanxyz
fix(module:modal): unable to close the mask if the container is OnPush
70a36b8 
close NG-ZORRO#2643
@hsuanxyz hsuanxyz mentioned this issue Dec 19, 2018
Closed
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Feb 2, 2019
@hsuanxyz
refactor(module:modal): use OnPush change detection
e2bd27d 
close NG-ZORRO#2643, close NG-ZORRO#2656
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Feb 13, 2019
@hsuanxyz
refactor(module:modal): use OnPush change detection
591b1b6 
close NG-ZORRO#2643, close NG-ZORRO#2656
@hsuanxyz hsuanxyz mentioned this issue Feb 13, 2019
Merged
5 tasks
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@hsuanxyz @Ricbet
refactor(module:modal): refactor modal component (NG-ZORRO#2869)
8f84188 
* refactor(module:modal): refactor block scroll strategy

close NG-ZORRO#2612

* docs(module:modal): update docs

* test(module:modal): update cases for scrollbar

* refactor(module:modal): use OnPush change detection

close NG-ZORRO#2643, close NG-ZORRO#2656

* fix(module:modal, drawer): IE/Edge SVG doesn't support `blur`/`focus` method

close NG-ZORRO#2388

* fix(module:modal): fix animations

* refactor(module:modal): switch to Default change detection

* docs: add temporary use case for IE

* fix: scrollblock style
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz @vthinkxie
refactor(module:modal): refactor modal component (NG-ZORRO#2869)
4304dc6 
* refactor(module:modal): refactor block scroll strategy

close NG-ZORRO#2612

* docs(module:modal): update docs

* test(module:modal): update cases for scrollbar

* refactor(module:modal): use OnPush change detection

close NG-ZORRO#2643, close NG-ZORRO#2656

* fix(module:modal, drawer): IE/Edge SVG doesn't support `blur`/`focus` method

close NG-ZORRO#2388

* fix(module:modal): fix animations

* refactor(module:modal): switch to Default change detection

* docs: add temporary use case for IE

* fix: scrollblock style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
🐛 Bug Component: Modal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HotEvent @hsuanxyz @IssueHuntBot