refactor(module:modal): refactor modal component #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 1ef10c3 |
Codecov Report
@@ Coverage Diff @@
## master #2869 +/- ##
=========================================
- Coverage 97.42% 97.4% -0.02%
=========================================
Files 523 524 +1
Lines 10961 10962 +1
Branches 781 785 +4
=========================================
- Hits 10679 10678 -1
- Misses 181 183 +2
Partials 101 101
Continue to review full report at Codecov.
|
hsuanxyz
force-pushed
the
refactor/modal
branch
from
e2bd27d to
591b1b6
Compare
hsuanxyz
changed the title
hsuanxyz
commented
Feb 14, 2019
| @@ -56,7 +56,7 @@ | |||
|
|
|||
| // https://github.com/angular/material2/issues/15051 | |||
| body { | |||
| overflow-x: unset; | |||
| overflow-x: visible; | |||
There was a problem hiding this comment.
IE does not support unset
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* refactor(module:modal): refactor block scroll strategy close NG-ZORRO#2612 * docs(module:modal): update docs * test(module:modal): update cases for scrollbar * refactor(module:modal): use OnPush change detection close NG-ZORRO#2643, close NG-ZORRO#2656 * fix(module:modal, drawer): IE/Edge SVG doesn't support `blur`/`focus` method close NG-ZORRO#2388 * fix(module:modal): fix animations * refactor(module:modal): switch to Default change detection * docs: add temporary use case for IE * fix: scrollblock style
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* refactor(module:modal): refactor block scroll strategy close NG-ZORRO#2612 * docs(module:modal): update docs * test(module:modal): update cases for scrollbar * refactor(module:modal): use OnPush change detection close NG-ZORRO#2643, close NG-ZORRO#2656 * fix(module:modal, drawer): IE/Edge SVG doesn't support `blur`/`focus` method close NG-ZORRO#2388 * fix(module:modal): fix animations * refactor(module:modal): switch to Default change detection * docs: add temporary use case for IE * fix: scrollblock style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onPushUsing OnPush for modal caused footer can not to detect changes. we can fix it when 8.x.
NZ_MODAL_CONFIGPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2612, #2388, #2643, #2656
What is the new behavior?
Does this PR introduce a breaking change?
Other information