Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: null state on providers first use #1182

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Mar 5, 2024

Closes #1174.
This PR changes the order of providers so that session provider is loaded before profile, exams and lectures providers.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #1182 (7b7bac4) into master (e2e949f) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1182   +/-   ##
======================================
  Coverage      16%     16%           
======================================
  Files         229     229           
  Lines        6951    6951           
======================================
  Hits         1086    1086           
  Misses       5865    5865           

@limwa limwa changed the title Limwa/hotfix/null state on providers first use hotfix: null state on providers first use Mar 5, 2024
@limwa limwa enabled auto-merge March 5, 2024 20:00
@LuisDuarte1 LuisDuarte1 disabled auto-merge March 5, 2024 21:14
@LuisDuarte1 LuisDuarte1 merged commit 3fbddeb into master Mar 5, 2024
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the limwa/hotfix/null-state-on-providers-first-use branch March 5, 2024 21:14
@LuisDuarte1
Copy link
Member

Force merged because it's kind of high priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants