-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use initial route instead of home widget #1190
Conversation
e5774d3
to
76dec25
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
======================================
+ Coverage 16% 17% +1%
======================================
Files 229 229
Lines 6957 6974 +17
======================================
+ Hits 1086 1144 +58
+ Misses 5871 5830 -41 |
Good news! From my testing, this does fix the bug of the SessionProvider state being null. However, when I log out of the app, my credentials are still there. After I click to log in, the password should be cleared. |
Note: When I log out and log back in, no lectures and exams show up, saying "Não existem aulas para apresentar".... I think this is something that we'll have to live for now... |
EDIT: fixed in #1192 |
I managed to fix this issue by adding a notifyListeners call on the state provider notifier. Can you please give it a try to ensure this doesn't introduce any other bugs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase the branch so that it can be merged into master
76dec25
to
8c925b3
Compare
@limwa I think setting the state null and removing the invalidate line as you suggested should be fine. I'll do it once I get to the PC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed formatting for you ;)
61663d9
to
a829ebe
Compare
Please add screenshots of the new button if you can! |
276ea5a
to
ece2f65
Compare
ece2f65
to
d09e8b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thank you 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 🚀 🧏♂️
Closes #1182
Closes #933
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change