Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract proguard rules at package level #1247

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

LuisDuarte1
Copy link
Member

@LuisDuarte1 LuisDuarte1 commented Jun 24, 2024

After some investigation on #1242, I've concluded that:

  • javax.annotations has annotations included in the JSR305, which is a spec of annotations that help with IDEs or other tools to avoid software defects.
  • com.google.errorprone has annotations related to ErrorProne, a static analyzer with its own set of annotations like above.

These annotations are not reflected at runtime in any shape or form so, it's safe to ignore them (unfortunately, libs cannot specify what to ignore or not on proguard, so we need to do this by hand).

This PR groups the two annotation packages.

@LuisDuarte1 LuisDuarte1 requested a review from a team June 24, 2024 21:04
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17%. Comparing base (3ab886a) to head (79694ec).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1247   +/-   ##
=======================================
+ Coverage       17%     17%   +1%     
=======================================
  Files          229     229           
  Lines         6965    6965           
=======================================
+ Hits          1149    1156    +7     
+ Misses        5816    5809    -7     

@limwa limwa requested a review from a team June 24, 2024 21:08
@thePeras thePeras merged commit 5775214 into develop Jun 25, 2024
4 checks passed
@thePeras thePeras deleted the fix/proguard-rules branch June 25, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants