Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract proguard rules at package level #1247

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Abstract proguard rules at package level #1247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e062843
Abstract proguard rules at package level
LuisDuarte1 Jun 24, 2024
79694ec
Merge branch 'develop' into fix/proguard-rules
DGoiana Jun 24, 2024
abbe72b
Merge branch 'develop' into fix/proguard-rules
thePeras Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions uni/android/app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
# hide the original source file name.
#-renamesourcefileattribute SourceFile

# The 6 lines below are added to fix #1243
-dontwarn com.google.errorprone.annotations.CanIgnoreReturnValue
-dontwarn com.google.errorprone.annotations.CheckReturnValue
-dontwarn com.google.errorprone.annotations.Immutable
-dontwarn com.google.errorprone.annotations.RestrictedApi
-dontwarn javax.annotation.Nullable
-dontwarn javax.annotation.concurrent.GuardedBy
# These are annotations related to static analysis tools. Proguard
# tries to optimize/obfuscate the bundle, it needs all
# packages to be present. Because these annotations do not exist
# at optimize time, it will warn us that it cannot find those packages.
# Unfortunaly, AFAIK there's no real way to packages include their "own"
# proguard or some of them just do not do it, so we sometimes need to handle it
# when we add a new dependency.

-dontwarn com.google.errorprone.annotations.*
-dontwarn javax.annotation.*