Skip to content

Commit

Permalink
[10.0][FIX] Make letsencrypt resilient for alternate name removal. (O…
Browse files Browse the repository at this point in the history
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
  • Loading branch information
NL66278 committed Dec 3, 2021
1 parent 7e47960 commit 77cc40b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions letsencrypt/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ Contributors

* Holger Brunn <hbrunn@therp.nl>
* Antonio Espinosa <antonio.espinosa@tecnativa.com>
* Dave Lasley <dave@laslabs.com>
* Ronald Portier <ronald@therp.nl>

ACME implementation
Expand Down
5 changes: 1 addition & 4 deletions letsencrypt/models/letsencrypt.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,10 @@ def call_cmdline(self, cmdline, loglevel=logging.INFO,
_logger.log(loglevel, stderr)
if stdout:
_logger.log(loglevel, stdout)

if process.returncode:
raise exceptions.Warning(
_('Error calling %s: %d') % (cmdline[0], process.returncode),
' '.join(cmdline),
_('Error calling %s: %d') % (cmdline[0], process.returncode)
)

return process.returncode

@api.model
Expand Down

0 comments on commit 77cc40b

Please sign in to comment.