Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] Make letsencrypt resilient for alternate name removal. #757

Merged
merged 3 commits into from
Apr 20, 2017

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented Feb 28, 2017

Sole #753 even before module is migrated.

@NL66278 NL66278 changed the title [FIX] Make letsencrypt resilient for alternate name removal. [10.0][FIX] Make letsencrypt resilient for alternate name removal. Feb 28, 2017
@NL66278
Copy link
Contributor Author

NL66278 commented Mar 1, 2017

Seems Travis is failing for all 10.0 branches. No idea why, because I do not see any logs or other pointers at what might be wrong.

@NL66278
Copy link
Contributor Author

NL66278 commented Mar 20, 2017

Now I see errors. Test on mail fails, because travis runs in environment were mail is not configured. So maybe we should either find a way to configure access to a mail server for testing purposes, or disable these tests on travis.

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I restarted Travis to hopefully clear the build

@lasley lasley merged commit 52d234f into OCA:10.0 Apr 20, 2017
mstuttgart pushed a commit to multidadosti-erp/server-tools that referenced this pull request Apr 20, 2017
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
eLBati pushed a commit to eLBati/server-tools that referenced this pull request Feb 14, 2019
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
daramousk pushed a commit to daramousk/server-tools that referenced this pull request Oct 2, 2019
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Feb 3, 2020
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
janverb pushed a commit to janverb/server-tools that referenced this pull request May 28, 2020
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
gfcapalbo pushed a commit to gfcapalbo/server-tools that referenced this pull request Jun 8, 2020
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
hbrunn pushed a commit to hbrunn/server-tools that referenced this pull request Jul 29, 2020
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
janverb pushed a commit to janverb/server-tools that referenced this pull request Aug 11, 2020
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Nov 19, 2020
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Mar 1, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Apr 7, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
hbrunn pushed a commit to hbrunn/server-tools that referenced this pull request Jun 14, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Jul 6, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
janverb pushed a commit to janverb/server-tools that referenced this pull request Jul 6, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
hbrunn pushed a commit to hbrunn/server-tools that referenced this pull request Aug 2, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Dec 3, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Dec 15, 2021
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Feb 9, 2022
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Feb 18, 2022
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
rquevedo pushed a commit to TRESCLOUD/server-tools that referenced this pull request Mar 22, 2022
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Apr 7, 2022
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
thomaspaulb pushed a commit to sunflowerit/server-tools that referenced this pull request Sep 1, 2022
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
NL66278 added a commit to NL66278/server-tools that referenced this pull request Sep 6, 2022
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
hbrunn pushed a commit to hbrunn/server-tools that referenced this pull request Apr 22, 2024
…CA#757)

* [FIX] Make letsencrypt resilient for alternate name removal.

* [FIX] Do not crash when returning error in letsencrypt cmdline.

* [FIX] Restore ordering by name for alternate domains in letsencrypt.

Conflicts:
	letsencrypt/README.rst
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants