Offshore merge #116
Merged
Offshore merge #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* liberate python 3.13 * actually liberate python * update testing * version number inequality fix * walkback python for backdated wisdem * propogate to tests
…re generic latent variable set up
New glue code. Refactor for simpler, more modular, and more automatic system construction.
* hotfix * add the actual hotfix * update all examples * added example testing routine to test * adjust cwd command * reorganize some examples * attempt fix * black reformat, pip statsmodels again after their hotfix * ok think i fixed it * cleanup runner * try system-agnostic runner * try system-agnostic runner again * indent fix * turn off n2 diagrams * test consolidated CI/CD workflow * attempt improved consolidated script * direct parallel example runner test * complete runner code * a new test that should maybe actually work * add missing file and quotation marks * switch to consolidated with parallel examples * rectify author attribution in pyproject.toml * remove commented dependency * cleaner gui interaction * modified consolidated tests * faster consolidated ci/cd * rollback action * take 2 on caching * update dependency * slight bugfix mod * try cache again * iterating on cicd cache * reorder * rename test * address some of jareds comments and remove commented code * black reformat
…shore-detailed example with 04_offshore_floating_detailed_mooring
cfrontin
reviewed
Jul 23, 2025
Collaborator
There was a problem hiding this comment.
this can get deleted, no?
cfrontin
reviewed
Jul 23, 2025
Collaborator
There was a problem hiding this comment.
this can get deleted, no?
cfrontin
reviewed
Jul 23, 2025
Collaborator
There was a problem hiding this comment.
this can get deleted, no?
Collaborator
There was a problem hiding this comment.
and so on for the other entries in test/data...
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request merges the develop branch into the offshore_development branch in preparation for bringing offshore development features into the main develop branch. The PR focuses on integrating offshore functionality, improving test infrastructure, and updating configuration handling.
Key changes include:
- Addition of comprehensive offshore mooring system test data and configuration files
- Implementation of utility functions for nested dictionary key-value replacement
- Refactoring of test files to use improved assertion patterns with subtests and updated modeling options
Reviewed Changes
Copilot reviewed 102 out of 115 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/utils/test_io.py | Adds tests for replace_key_value utility function with nested dictionary handling |
| test/unit/ard/offshore/test_mooringdesigndetailed.py | Updates test configuration with new file paths and adds data_path parameter |
| test/unit/ard/offshore/inputs/OntologySample200m.yaml | Adds mooring system configuration data for offshore tests |
| test/unit/ard/offshore/inputs/GulfOfMaine_bathymetry_100x99.txt | Adds bathymetry data file for offshore mooring tests |
| test/unit/ard/layout/test_spacing.py | Removes unused JAX imports to clean up dependencies |
| test/unit/ard/layout/test_gridfarm.py | Adds default modeling options for farm spacing parameters |
| test/unit/ard/farm_aero/test_templates.py | Moves wind query initialization and updates parameter passing |
| test/unit/ard/farm_aero/test_floris.py | Refactors test assertions to use subtests and improves pyrite validation |
| test/unit/ard/cost/test_wisdem_wrap.py | Updates test structure with subtests and adds required modeling options |
| test/unit/ard/collection/test_templates.py | Adds missing farm configuration parameters and updates expected outputs |
Comments suppressed due to low confidence (1)
test/unit/ard/farm_aero/test_templates.py:95
- Removed wind_query parameter but the modeling_options may not contain the wind_rose yet. Ensure wind_rose is properly set in modeling_options before removing the explicit parameter.
),
cfrontin
approved these changes
Jul 30, 2025
…isclose to allclose
jaredthomas68
merged commit 48e48b7
into
NLRWindSystems:offshore-development
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging
developbranch inoffshore_developmentin preparation for bringingoffshore_developmentintodevelop