Mooring Offshore development

[lsirkis]

Overview
The proposed changes will integrate FAModel into Ard for mooring resizing.

Details

• The method buildFAModel() was developed in the DetailedMooringDesign class to initialize an FAModel project from various input options
• buildFAModel() is called in the setup() method to initialize
• The FAModel project object is stored as a property of the DetailedMooringDesign class, under the name FAM (can be altered)
• In compute() method, the repositionArray() method of the FAModel object is called to update platform, mooring, and anchor positions based on x,y, and phi platform inputs. This method also resizes mooring lines and resets anchor positions to match bathymetry its new position. Platform x,y locations are converted to m from km before being passed to FAModel.repositionArray() to ensure unit accuracy.
• Currently, the FAM.repositionArray() returned values (mooring and anchor costs) are not stored in a variable in the DetailedMooringDesign.compute() method, but when the desired variable name/location is determined this information will be stored.
• Anchor x,y locations are also pulled out of the FAModel object and converted to km to match Ard units

[Copilot]

Pull Request Overview

This PR integrates the FAModel library into Ard for detailed mooring resizing and positioning.

• Added sample soil and bathymetry input files for offshore mooring examples
• Extended analysis_demo.py to configure mooring_setup with the new adjuster
• Updated DetailedMooringDesign: added buildFAModel, initialized self.FAM, performed unit conversions, and repositioned moorings & anchors in compute()

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File	Description
examples/offshore-detailed/soil_sample.txt	Added a template soil input file
examples/offshore-detailed/bathymetry200m_sample.txt	Added a template bathymetry input file
examples/offshore-detailed/analysis_demo.py	Imported adjustMooring and added mooring_setup config
ard/offshore/mooring_design_detailed.py	Introduced buildFAModel, FAM initialization, reposition logic, and unit conversions

Comments suppressed due to low confidence (4)

ard/offshore/mooring_design_detailed.py:130

• [nitpick] The attribute name FAM is uppercase, which deviates from Python snake_case conventions; consider renaming it to fa_model or fam_model for consistency.

self.FAM = self.buildFAModel(**self.options['modeling_options']['mooring_setup'])

ard/offshore/mooring_design_detailed.py:127

• [nitpick] The new mooring_setup path and buildFAModel logic are not covered by existing tests; please add unit tests to verify correct model initialization and repositioning behavior.

if 'mooring_setup' not in self.options['modeling_options']:

ard/offshore/mooring_design_detailed.py:190

• The code uses np.array but there is no import numpy as np at the top of the file; please add the import to avoid a NameError.

self.FAM.repositionArray(np.array([[x_turbines[i],y_turbines[i]] for i in range(len(x_turbines))]),

ard/offshore/mooring_design_detailed.py:208

• Reassigning outputs to a new dict shadows the OpenMDAO outputs object and prevents values from being recorded; remove this reassignment and write directly to the provided outputs parameter.

outputs = {}

[cfrontin]

ok, let's start by applying this diff

diff --git a/pyproject.toml b/pyproject.toml
index d3b36b2..5518d64 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -43,6 +43,8 @@ dependencies = [
   "jax",
   "optiwindnet",
   "highspy",
+  "moorpy @ git+https://github.com/NREL/MoorPy.git@dev",
+  "famodel @ git+https://github.com/FloatingArrayDesign/FAModel.git@main",
 ]
 [project.optional-dependencies]
 dev = [

I think that should get everything installed and allow the tests to be meaningful.

@lsirkis can you apply this diff to your branch and push?

[cfrontin]

here's come context on how the test classes work: for each method of the class that begins with test_, a new test will be run. each test is run in a sandbox: it won't communicate with the scope outside that feature, with one major exception: before each test is run, setup_method will be re-run. it sets up the sandbox that a test is run in. so here, you've got this setup step happening but for the most part the objects created aren't being used in the tests so far.

[cfrontin]

JUST KIDDING, you are definitely using these. REDACT REDACT REDACT

[cfrontin]

mismatch on spacing diameter count