Phase out Shapely (Issue #103) #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akey7
suggested changes
Feb 3, 2020
Contributor
akey7
left a comment
akey7
left a comment
There was a problem hiding this comment.
The ErectionCost calculations are off from the known validation data. Please see the differences in the email with inputs and outputs I sent previously.
eberlea
reviewed
Feb 5, 2020
Contributor
eberlea
left a comment
eberlea
left a comment
There was a problem hiding this comment.
Thanks for fixing the bug, Parangat. This looks good to me. Please confirm with Alicia before merging.
Contributor
|
I ran the validation and it passes. I also looked at the changes to the file. Approving PR! |
akey7
approved these changes
Feb 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Shapely's Polygon and Point classes with Sympy's Polygon and Point classes; Sympy's Polygon and Point classes are quite identical in their capabilities to those of Shapely, which made the process of replacing Shapely from LandBOSSE quite straightforward (once the alternative was found that is!).