Remove shapely from LandBOSSE - Issue #151 #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
While the SymPy point/polygon crashes Travis CI, it runs fine on my macOS machine. I am going to go ahead and merge this into develop only and we can look into the Travis build later. |
akey7
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced shapely with sympy.
Please note, shapely was phased out and replaced with sympy back in February '20 (refer to issue #103 and PR #104). However, due to the timing of that change coinciding with the then ongoing cost and scaling work, PR #104 was merged into pip_installable branch only (not develop) to (1) prevent any possible disruption of the cost & scaling work (as in, introduction of bugs for instance), and (2) it was only needed at that point in time for the LandBOSSE / SAM integration project.
This PR has made the exact same changes to the ErectionCost.py file (compared to PR #104); this PR is focusing now on phasing out shapely (and replacing with sympy) for the develop branch.