Fixed double logging mixing UseNLog with AddNLog #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@304NotModified Anything else that is needed for release of NLog.Web + NLog.Web.AspNetCore 4.8.5 ? |
|
Only release notes etc. |
This was referenced Sep 24, 2019
|
This change had the unwanted side-effect that NLog replaced any previously added logging-provider. See also IServiceCollection.Replace Created #485 to only look at other NLog-LoggingProviders using IServiceCollection.TryAddEnumerable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also NLog/NLog.Extensions.Logging#325
Requires release of NLog.Extension.Logging 1.5.4