Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(already hotfixed) Fixed: Mixing AddDebug() with a file based NLog configuration no longer works #485

Merged
merged 2 commits into from
Sep 30, 2019
Merged

(already hotfixed) Fixed: Mixing AddDebug() with a file based NLog configuration no longer works #485

merged 2 commits into from
Sep 30, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 29, 2019 •
edited by 304NotModified
Loading

Fixed bug introduced with IServiceCollection.Replace. Instead use TryAddEnumerable

Bug was introduced in NLog.Web.AspNetCore ver. 4.8.5 by #459

Also updated the obsolete-descriptions

@snakefoot snakefoot mentioned this pull request Sep 30, 2019
Closed
@snakefoot snakefoot changed the title Updated obsolete-message for ConfigureNLog-methods Fixed bug introduced with IServiceCollection.Replace. Instead use TryAddEnumerable Sep 30, 2019
@snakefoot snakefoot mentioned this pull request Sep 30, 2019
Merged
@304NotModified 304NotModified merged commit e8e4efe into NLog:dev Sep 30, 2019
@304NotModified
Copy link
Member

Thanks!

@304NotModified
Copy link
Member

Maybe this should be 4.8.6? (So to master)

@snakefoot
Copy link
Contributor Author

snakefoot commented Sep 30, 2019 •
edited
Loading

Maybe this should be 4.8.6? (So to master)

Depends on how far ver. 4.9.0 is from being complete. Would have to be a custom commit, since this cannot be merged to master.

@304NotModified
Copy link
Member

304NotModified commented Sep 30, 2019 •
edited
Loading

Well I like to have the docs and .NET Core 3 things ready for 4.9. Unfortunately I have issues with asp.net core on my machine, so that stalls everything (also the Travis issue is a blocker, maybe skip that one for now)

I will cherry-pick this bugfix for 4.8.6. now as I think it's important to not force a minor upgrade for a fix.

@304NotModified 304NotModified changed the title Fixed bug introduced with IServiceCollection.Replace. Instead use TryAddEnumerable Fixed: Mixing AddDebug() with a file based NLog configuration no longer works Sep 30, 2019
@304NotModified 304NotModified mentioned this pull request Sep 30, 2019
Merged
@304NotModified
Copy link
Member

note: fixed in 4.8.6 with #487

@304NotModified 304NotModified changed the title Fixed: Mixing AddDebug() with a file based NLog configuration no longer works (already hotfixed) Fixed: Mixing AddDebug() with a file based NLog configuration no longer works Sep 30, 2019
@snakefoot
Copy link
Contributor Author

snakefoot commented Oct 16, 2019 via email •
edited
Loading

@snakefoot snakefoot mentioned this pull request Oct 19, 2019
Merged
@snakefoot
Copy link
Contributor Author

Created PR NLog/NLog.Extensions.Logging#350

@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed already-hotfixed labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions size/S
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified