Load alt default theme if true color is not supported #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move `runtime/themes/base16_default_terminal.toml` to `base16_theme.toml` alongside `theme.toml` * Use `terminfo` crate to detect whether the terminal supports true color and, if the user has no theme configured and their terminal does not support true color, load the alt default theme instead of the normal default.
If the terminal is wrongly detected to not support true color, `true-color-override = true` will override the detection.
archseer
reviewed
Nov 29, 2021
archseer
reviewed
Nov 29, 2021
archseer
reviewed
Nov 29, 2021
Omnikar
force-pushed
the
16-color-default
branch
from
ec9d4e1 to
f037cf8
Compare
|
@Omnikar sorry for the late reply, could you help me resolve this branch conflict please? |
kirawi
reviewed
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the functionality of helix-editor#1078 needed to finish helix-editor#791
runtime/themes/base16_default_tty.tomlto./base16_theme.tomlalongsidetheme.toml.UseChanged to checkingterminfocrate to detect whether the terminal supports truecolor and, if the user has no theme configured and their terminal does
not support true color, load the alt default theme instead of the
normal default.
COLORTERMenv variable on non-Windows and assuming true color support on Windows.