Fix Base16 default dark, Add Base16 default light, terminal, tty

[NNBnh]

• Fix Base16 default dark:
  • Fix some typo.
  • Make the styling more accurate.
  • Improve contrast.
• Add Base16 default light.
• Add Base16 terminal & Base16 tty:
  • This is Base16 with Terminal color which could close Create an alternative default theme for 16 color terminals #791.
  • Some options with "white" foreground have a #FIXME comment at the end, that because the intent foreground color is "default" (which does not exist) not "white". If we remove that options, the color will not fall back to the default foreground terminal color, but turn into a strange blue color:

Current:

Remove options with #FIXME:

other blue UI is the picker:

I'm currently running Helix 0.5.0.

[archseer]

* f we remove that options, the color will not fall back to the default foreground terminal color, but turn into a strange blue color:

Hmm yeah, this was added because we normally always expect a style to be returned, this way if a theme color is missing it'll stand out.

helix/helix-view/src/theme.rs

Line 122 in 9d59142

.unwrap_or_else(|| Style::default().fg(Color::Rgb(0, 0, 255)))

Maybe we should only do that in debug builds?

[EpocSquadron]

@archseer maybe it's better to add a "foreground" and "background" keyword similar to the ansi color names, rather than behaving differently depending on type of build.

[Omnikar]

This PR does not do this:

Embed it in the editor just like the default theme, and then, if the user doesn't have a theme configured, detect whether their terminal supports full color, and use the 16 color alternate default theme if it doesn't.

However, I was able to implement it here: NNBnh#1

[archseer]

Oof, terminfo pulls in a lot of dependencies. term seems a bit more lightweight: https://docs.rs/term/0.7.0/term/terminfo/struct.TermInfo.html

[archseer]

Both are unmaintained though. I wonder if we could just send a raw query

[EpocSquadron]

@archseer a robust terminfo parser could be useful for further features though. I've been eyeing curly underline, double underline with separate colors from the text, like kakoune just added (I requested it there long ago). We would need to feature detect that with terminal.

[archseer]

Yeah I was thinking we could copy over term::terminfo submodule and maintain it ourselves if necessary. It's still passively maintained upstream so we could rely on the crate for the time being.

[Omnikar]

Oof, terminfo pulls in a lot of dependencies. term seems a bit more lightweight: https://docs.rs/term/0.7.0/term/terminfo/struct.TermInfo.html

Hm, I'm not sure what to actually use to check for true color support?

[archseer]

Let's check the COLORTERM env variable, as suggested by https://gist.github.com/XVilka/8346728#checking-for-colorterm

We will probably need to add a config option truecolor = true to force override on terminals that don't set this correctly.

[Omnikar]

OK, I've done that, and with the addition of the false negative override, I've also made it so that it will reject :theme invocations and theme = configurations that try to set an unsupported theme.

[archseer]

@NNBnh can you merge Omnikar's PR?

[archseer]

And please change

helix/helix-view/src/theme.rs

Line 122 in 9d59142

.unwrap_or_else(|| Style::default().fg(Color::Rgb(0, 0, 255)))

to be .unwrap_or_default(). That will fix the blue colors

[archseer]

Oh also note that base16_terminal is not a good default for 16 color terminals if the user isn't using a base16 theme. The default should use the regular ANSI palette where 0-7 are not shades of gray, but colors.

#833 (comment)

[NNBnh]

The default should use the regular ANSI palette where 0-7 are not shades of gray, but colors.

Yeah, I'm thinking or creating another theme base16_tty that display well on every terminal even Linux's tty ( Ctrl + Alt + F3 ... ).

After that i will figure it out how to merge with Omnikar's PR (I'm not pro enough with git and github).

[NNBnh]

All Base16 themes have problem on Helix 0.5: all line-number have an one character width gap where it just show the editor's background and not the line-number's background.

This gap it's not be created by the terminal, we can see that the statusline can still expand to that gap and the gap is also appear on split buffer.

It's this bug fixed on the current branch?

[archseer]

That's the diagnostics gutter.

[NNBnh]

Okay i fixed it, look like everything here is done! Please merge the branch before something get conflict.

[archseer]

Since all these info/debug/warning/error colors are used in places besides the gutter, I don't recommend setting bg. Instead a new UI scope should be added ui.gutter that will be used for all the gutters including line numbers. You can add the styling here and I'll patch it in later

[NNBnh]

Okay changed to:

"ui.gutter" = { bg = "black" }
"info" = "gray"
"hint" = "gray"
"debug" = "gray"
"warning" = "yellow"
"error" = "red"

Is this correct?

[archseer]

Let's make info light blue.

[NNBnh]

Changed info:

• base16_default_dark.toml: base0D
• base16_default_light.toml: base0D
• base16_terminal.toml: light-blue
• base16_theme.toml: blue (instead of light-blue because for compatibility for all terminal, the default theme should not contain light variant color)

[archseer]

I incorrectly pushed this.. will merge directly into master

[archseer]

Pushed! 43d17c4..730d3be