-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize package content #194
Conversation
This will also simplify #185, eventually. |
@felixhekhorn do you actually want a review now, or are you just attracting our attention on the topic? |
no, not yet - I want to attempt the move into |
Maybe we should make a poll about how to sort external dimensions, currently:
I'm positive about keeping 4 and 5 in their current position, encoding them in modules and functions respectively. But I'm quite unopinionated on the first three. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test are passing, so these changes should be enough :)
For review: please @alecandido @niclaurenti @giacomomagni have a look now
|
The base branch was changed.
4c72a96
to
07aa331
Compare
The idea is to split the hard math away from the other administrative stuff (such as how to join operators etc.). This would be a small step towards #185 and eventually #189.