Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force process grouping in theorycovariance module #1135

Merged
merged 11 commits into from
Mar 10, 2021
Merged

Force process grouping in theorycovariance module #1135

merged 11 commits into from
Mar 10, 2021

Conversation

RosalynLP
Copy link
Contributor

Addresses #791

@RosalynLP
Copy link
Contributor Author

RosalynLP commented Mar 9, 2021 •
edited
Loading

Actions that need proc counterparts:

  • groups_central_values
  • groups_central_values_no_table
  • groups_data_values
  • groups_data
  • groups_index
  • groups_covmat
  • groups_normcovmat
  • groups_corrmat
  • groups_results
  • group_result_table
  • group_result_table_no_table
  • groups_chi2_table

@RosalynLP RosalynLP marked this pull request as ready for review March 9, 2021 11:14
@RosalynLP
Copy link
Contributor Author

OK so this is now working for me, in that I can take "metadata_group: nnpdf31_process" out of the runcard and all of the svarn and plotting is still done by process type as it should be.

@RosalynLP RosalynLP requested review from voisey and wilsonmr March 9, 2021 11:22
@wilsonmr
Copy link
Contributor

I think on the whole it looks fine

@scarrazza scarrazza merged commit 22bcae0 into master Mar 10, 2021
@scarrazza scarrazza deleted the force_process_grouping branch March 10, 2021 15:16
@voisey
Copy link
Contributor

voisey commented Mar 11, 2021

Hey @RosalynLP, I've just closed #791 but please reopen it if it's not fully addressed by this PR for some reason. Btw, not sure if you know this or not but if you want to close an issue when you merge a PR (which I assume you wanted to do here?) there are certain keywords you have to use, see https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue. Apologies if you didn't actually want to close it 😛

@RosalynLP
Copy link
Contributor Author

@voisey Thanks didn't realise you could do this :)

@voisey voisey mentioned this pull request Mar 15, 2021
Merged
@RosalynLP RosalynLP mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonmr wilsonmr wilsonmr left review comments

@voisey voisey Awaiting requested review from voisey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RosalynLP @wilsonmr @voisey @scarrazza