Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore ATM local ensemble ctest functionality #1003

Merged
merged 3 commits into from
Mar 28, 2024
Merged

restore ATM local ensemble ctest functionality #1003

merged 3 commits into from
Mar 28, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

g-w develop commit 47302153 modified how EUPD_CYC is set in config.base. This variable is now set in a configuration yaml. This requires a change in how test_gdasapp_atm_jjob_ens is configured. This PR include the required change.

Fixes #1002

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Mar 28, 2024
@RussTreadon-NOAA RussTreadon-NOAA added the orion-GW-RT Queue for automated testing with global-workflow on Orion label Mar 28, 2024
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed orion-GW-RT Queue for automated testing with global-workflow on Orion labels Mar 28, 2024
@emcbot
Copy link

emcbot commented Mar 28, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Mar 28 10:35:16 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Mar 28 11:27:14 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Mar 28 11:53:07 CDT 2024
Tests: 94% tests passed, 3 tests failed out of 53
	1737 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1771 - test_gdasapp_atm_jjob_var_run (Failed)
	1772 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1003/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Mar 28, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

The test_gdasapp_fv3jedi_fv3inc and test_gdasapp_atm_jjob_var_run failures appear to be related to GDASApp hash 18ba5da. Does this sound reasonable @DavidNew-NOAA ?

@RussTreadon-NOAA
Copy link
Contributor Author

test_gdasapp_atm_jjob_ens Passed with the changes in this PR

50/53 Test #1773: test_gdasapp_atm_jjob_ens_init ........................   Passed   44.25 sec
      Start 1774: test_gdasapp_atm_jjob_ens_run
51/53 Test #1774: test_gdasapp_atm_jjob_ens_run .........................   Passed  330.24 sec
      Start 1775: test_gdasapp_atm_jjob_ens_final
52/53 Test #1775: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.24 sec

As such, I think this PR is ready for review, approval, and merger into GDASApp develop.

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA : I see g-w PR #2420. I assume that if I build RussTreadon-NOAA:feature/eupd_cyc inside a working copy of DavidNew-NOAA:feature/jediinc2fv3, the Failed tests in this PR should change to Passed. Does this sound right?

@DavidNew-NOAA
Copy link
Collaborator

@DavidNew-NOAA : I see g-w PR #2420. I assume that if I build RussTreadon-NOAA:feature/eupd_cyc inside a working copy of DavidNew-NOAA:feature/jediinc2fv3, the Failed tests in this PR should change to Passed. Does this sound right?

@RussTreadon-NOAA Yes, that's correct for the test_gdasapp_fv3jedi_fv3inc test. I assume that's the case for the test_gdasapp_atm_jjob_var_run, but I'm realizing now that I may have needed to modify those jjob tests in the my GDASApp PR, given that g-w PR #2420 changes the structure and names of two atmanl jobs. I need to investigate.

@DavidNew-NOAA
Copy link
Collaborator

OK, so JGLOBAL_ATM_ANALYSIS_RUN is now JGLOBAL_ATM_ANALYSIS_VARIATIONAL in g-w branch feature/jediinc2fv3 will break the test_gdasapp_atm_jjob_var_run test. I will need to do a quick bugfix PR into GDASApp develop. Thanks for feedback.

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA , thanks for letting me know. Instead of you opening a new issue to fix ATM variational ctest functionality, I can modify the description of this issue and make the change in my branch. Does this work for you?

@DavidNew-NOAA
Copy link
Collaborator

@DavidNew-NOAA , thanks for letting me know. Instead of you opening a new issue to fix ATM variational ctest functionality, I can modify the description of this issue and make the change in my branch. Does this work for you?

@RussTreadon-NOAA Sure, that would be great, thank you. However, in addition do modifying the run job test, a new test will need to be made for the new job JGLOBAL_ATM_ANALYSIS_FV3_INCREMENT (gdasatmanlfv3inc), which is added in feature/jediinc2fv3.

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA: OK, I see. I jumped before looking. While the changes for adding an new job step are straight forward, I may not get everything in place and tested before I go on leave COB tomorrow. Given this, it's preferable to limit this PR to test_atm_jjob_ens and open a new issue & PR to expand test_atm_jjob_var to with with the new job.

@DavidNew-NOAA
Copy link
Collaborator

Ok, sounds good.

@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA , @guillaumevernieres , or @DavidNew-NOAA : would one of you review these changes and approve so we can merge this fix into GDASApp develop.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CoryMartin-NOAA . Merging now.

RussTreadon-NOAA
RussTreadon-NOAA commented Mar 28, 2024
View reviewed changes
Copy link
Contributor Author

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix

@RussTreadon-NOAA RussTreadon-NOAA merged commit ed441fd into NOAA-EMC:develop Mar 28, 2024
2 checks passed
@DavidNew-NOAA
Copy link
Collaborator

DavidNew-NOAA commented Mar 29, 2024 via email

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA : Yes, please open an issue to document the fact that the test_gdasapp_atm_jjob_var suite is now incomplete given the new fv3inc job.

danholdaway added a commit that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'origin/develop' into feature/use_jcb_atm
b256b0f 
* origin/develop:
  Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026)
  Change generate_com to declare_from_tmpl (#1025)
  Commenting out more of the marine bufr 2 ioda stuff (#1018)
  make driver consistent with workflow driver (#1016)
  Update hashes now that GSI-B is working for EnVar (#1015)
  Add GitHub CLI to path for CI (#1014)
  Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013)
  Fix inconsistent VIIRS preprocessing test (#1012)
  remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010)
  Bugfix on Broken GHRSST Ioda Converter (#1004)
  Moved the marine converters to a "safe" place (#1007)
  restore ATM local ensemble ctest functionality (#1003)
  Add BUFR2IODA python API converter to prepoceanobs task (#914)
  Remove sst's from obs proc (#1001)
  JEDI increment write to cubed sphere history (#983)
  [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define EUPD_CYC for ATM local ensemble ctest
4 participants
@RussTreadon-NOAA @emcbot @DavidNew-NOAA @CoryMartin-NOAA