Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1009) #1010

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

There is a typo in the executable filename referenced by test_gdasapp_fv3jedi_fv3inc. The prefix gdas_ is not needed. This PR removes gdas_

Fixes #1009

@RussTreadon-NOAA
Copy link
Contributor Author

@DavidNew-NOAA and @CoryMartin-NOAA: This PR is a quick fix to get test_gdasapp_fv3jedi_fv3inc working.

Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. There were a lot of name changes.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 3c9cdaa into develop Mar 29, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/test_gdasapp_fv3jedi_fv3inc branch March 29, 2024 13:29
danholdaway added a commit that referenced this pull request Apr 8, 2024
* origin/develop:
  Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026)
  Change generate_com to declare_from_tmpl (#1025)
  Commenting out more of the marine bufr 2 ioda stuff (#1018)
  make driver consistent with workflow driver (#1016)
  Update hashes now that GSI-B is working for EnVar (#1015)
  Add GitHub CLI to path for CI (#1014)
  Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013)
  Fix inconsistent VIIRS preprocessing test (#1012)
  remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010)
  Bugfix on Broken GHRSST Ioda Converter (#1004)
  Moved the marine converters to a "safe" place (#1007)
  restore ATM local ensemble ctest functionality (#1003)
  Add BUFR2IODA python API converter to prepoceanobs task (#914)
  Remove sst's from obs proc (#1001)
  JEDI increment write to cubed sphere history (#983)
  [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_gdasapp_fv3jedi_fv3inc fails due to executable name mismatch
3 participants