-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port OznMon's non-operational components to wcoss2 #349
Conversation
@DavidHuber-NOAA if you have a moment can you take a look at these changes? Thanks. |
…to wcoss2. Completes NOAA-EMC#347.
31f73e2
to
b73a796
Compare
@EdwardSafford-NOAA speaking with Rahul on Friday, he said that it wouldn't be an issue to go ahead and merge this work to the master. However, after seeing your comments on PR #327, I do see that there could be additional cleanup work for the monitoring packages. So, if you would prefer to close this PR for the time being and readdress it after PR #327 is merged to the authoritative repository, that is fine. |
@MichaelLueken-NOAA Yes, I'd prefer to close this PR and reissue it after the cleanup and retesting. Not trying to rush you, but when do you anticipate #327 will be merged into the repository? |
@EdwardSafford-NOAA Right now, there is an update out to the review committee that will be merged to the authoritative repository tomorrow - PR #328. After that, the GFS v16.x changes will take priority. There are currently two updates that will need to go in for GFS v16.x - PR #345 and PR #350. Once these two have been merged, then I will work on PR #327. Having said that, Andrew is also working on an update for GFS v16.x, which will take priority if he creates a PR before #345 and #350 have been merged to the authoritative repository. So, anywhere between two and three weeks, depending on if Andrew creates a PR, otherwise, two weeks for the review committee to review the two GFS v16.x changes. |
Per discussion above I'm closing this PR and will integrate and retest following the implementation of PR #327. |
Ported components include build, developer data extraction/copy, image generation, and file transfer scripts.
Note that operational portions of package were previously ported to wcoss2 under #227.