Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#423. Replace ncio/1.0.0 with ncio/1.1.2. #430

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

MichaelLueken
Copy link
Contributor

Replace ncio/1.0.0 with ncio/1.1.2 in modulefiles/gsi_common.lua and add commands to load ncio/1.1.2 from para for WCOSS2 in gsi_wcoss2.lua. Updated ncio version in ci/spack.yaml from 1.0.0 to 1.1.2.

Closes #423

…common.lua and add commands to load ncio/1.1.2 from para for WCOSS2 in gsi_wcoss2.lua. Updated ncio version in ci/spack.yaml from 1.0.0 to 1.1.2.
@MichaelLueken MichaelLueken requested a review from aerorahul July 8, 2022 15:44
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks @MichaelLueken-NOAA

Just a note: ncdiag is also in the para space of WCOSS2.
It is already installed on Hera and Orion.
Possibly create an issue and open a PR to remove ncdiag submodule.

@MichaelLueken
Copy link
Contributor Author

Thanks for the review, @aerorahul! I have created issue #431 to remove the ncdiag submodule and replace it with the hpc-stack built ncdiag/1.0.0 library.

@MichaelLueken
Copy link
Contributor Author

Since there are no changes to the source code and @aerorahul has approved, I will now give final approval and merge this work to the authoritative develop branch.

@MichaelLueken MichaelLueken merged commit 1a3fb13 into NOAA-EMC:develop Jul 8, 2022
@MichaelLueken MichaelLueken deleted the feature/ncio_1.1.2 branch August 31, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Availability of ncio/1.1.2 on WCOSS2 and replacing ncio/1.0.0 with ncio/1.1.2 in gsi_common.lua
2 participants